GH Actions: split test jobs #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With PHPCS 4.x around the corner, the matrix for the PHP/PHPCS combis will become more complex, making all inline conditions more complex too. Splitting the test jobs into two separate jobs, one where only the PHP version changes, one where both the PHP version + the PHPCS version changes, will allow for making the adjustments needed for PHPCS 4.x and still keep the jobs stable, readable and maintainable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With PHPCS 4.x around the corner, the matrix for the PHP/PHPCS combis will become more complex, making all inline conditions more complex too.
Splitting the test jobs into two separate jobs, one where only the PHP version changes, one where both the PHP version + the PHPCS version changes, will allow for making the adjustments needed for PHPCS 4.x and still keep the jobs stable, readable and maintainable.